feat: split out docs/react routes from shared MdxRoute file#1222
Closed
jderochervlk wants to merge 2 commits intomasterfrom
Closed
feat: split out docs/react routes from shared MdxRoute file#1222jderochervlk wants to merge 2 commits intomasterfrom
jderochervlk wants to merge 2 commits intomasterfrom
Conversation
jderochervlk
force-pushed
the
vlk/split-out-docs-manual
branch
3 times, most recently
from
de2ead6 to
5d7a8f2
Compare
- Create DocsReactRoute.res/.resi for /docs/react/* pages, following the same pattern as MdxRoute with React-specific sidebar categories (Overview, Main Concepts, Hooks & State Management, Guides) and breadcrumbs (Docs > rescript-react) - Register docsReactRoutes in app/routes.res via MdxFile.scanPaths and filter docs/react paths out of the legacy mdxRoutes - Fix inconsistent comparator in Mdx.sortSection: items with an order field now always sort before items without one, and items without order preserve their relative position
jderochervlk
force-pushed
the
vlk/split-out-docs-react
branch
from
5bbdac3 to
1e11df4
Compare
9 tasks
…nto vlk/split-out-docs-react
Cloudflare deploymentDeployement ID: 9e481ca6-d2d8-4c57-8dad-54c02bad1b68 ⛅️ wrangler 4.63.0 (update available 4.81.1) ✨ Uploading _redirects |
jderochervlk
added a commit
that referenced
this pull request
Apr 12, 2026
- Delete MdxRoute.res/.resi (all pages now handled by split routes) - Remove react-router-mdx from package.json and delete yarn patch - Remove react-router-mdx externals from Mdx.res - Remove mdxRoutes binding from ReactRouter.res - Remove react-router-mdx init from react-router.config.mjs and generate-route-types.mjs - Add DocsManualRoute for /docs/manual pages with sidebar and TOC - Add DocsReactRoute for /docs/react pages with sidebar and TOC - Add SyntaxLookupDetailRoute for /syntax-lookup/* detail pages - Add SidebarHelpers module for shared sidebar nav/category generation - Add MdxFile.loadAllAttributes to replace react-router-mdx loadAllMdx - Migrate BlogRoute to use MdxFile.loadAllAttributes - Migrate SyntaxLookupRoute to use MdxFile.loadAllAttributes - Migrate CommunityRoute to use SidebarHelpers and MdxFile.loadAllAttributes - Fix Mdx.sortSection comparator to handle all cases explicitly - Update routes.res to register all split routes and remove mdxRoutes Combines PRs #1221, #1222, #1225, #1227
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This work was done with AI assistance